Guided Project CIA Factbook feedback

Share Projects
#1

I would want to know, what can be improved.

https://app.dataquest.io/jupyter/notebooks/notebook/CIA%20Factbook.ipynb#

CIA+Factbook.ipynb (53.1 KB)

Click here to view the jupyter notebook file in a new tab

#2

Hi @sudarshanawasthi47 !
Thanks for sharing your project here. I just posted my own version of the CIA Factbook SQL project, and I was excited to see how other folks approached it. One of the first things that I noticed when I saw your project was that you use your headers to effectively organize your project. It makes it a lot easier to scan the entire document when there are those visual anchors.

I found it a bit more challenging to scan your code cells. I would encourage you to take a look at the SQL Style Guide, particularly the section on white space. They recommend that you organize the code not based on 4-space indents (like we do in python), but rather with right justification of each command For example:

Python style indentation

def a_function(foo):
    for i in range(len(foo)):
        bar[i] = foo[i] + 2
    return bar

SQL style indentation

SELECT foo, bar
  FROM data
 WHERE data > 0
 ORDER BY bar

The style guide calls it a ‘river’ running down the center of your query, which makes it easy to ID commands at a glance.
Hopefully that is a helpful suggestion!
– ChefPaul92